Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time input selection in flexible layout causes plot requery #5874

Closed
3 of 7 tasks
davetsay opened this issue Oct 14, 2022 · 4 comments
Closed
3 of 7 tasks

Time input selection in flexible layout causes plot requery #5874

davetsay opened this issue Oct 14, 2022 · 4 comments
Labels
bug:regression It used to work. Now it doesn't :( help_wanted Help the Open MCT project! needs:e2e Needs an e2e test performance impacts or improves performance severity:medium type:bug
Milestone

Comments

@davetsay
Copy link
Contributor

davetsay commented Oct 14, 2022

Summary

Selecting and highlighting the start or end input field of the time conductor can trigger an unwanted plot requery from within a flexible layout.

Expected vs Current Behavior

Plots should not be requeried unless the time range changes

Steps to Reproduce

  1. Create a flexible layout
  2. Add an overlay plot with telemetry
  3. Add another plot with telemetry
  4. Save flexible layout
  5. Open browser dev tools and navigate to the network tab
  6. Toggle independent time conductor in one of the plots
  7. In the toggled independent time conductor, click and drag inside start or end bounds inputs to highlight time to change
  8. Observe that plots requery even though time bounds have not yet changed

Environment

  • Open MCT Version:
  • Deployment Type:
  • OS:
  • Browser:

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

@akhenry
Copy link
Contributor

akhenry commented Oct 29, 2022

Not this again...This is a regression, so we need to make sure we define an e2e for it.

@akhenry akhenry added this to the 2.1.3 milestone Oct 29, 2022
@akhenry akhenry added the bug:regression It used to work. Now it doesn't :( label Oct 29, 2022
@akhenry
Copy link
Contributor

akhenry commented Oct 29, 2022

Reclassifying as medium because it has no functional impact and really shouldn't happen that often. I do want to fix it quickly though, so I've scoped it for 2.1.3. This is an annoying regression.

@davetsay davetsay self-assigned this Nov 23, 2022
@davetsay davetsay added the bug:retest Retest without a specific milestone label Nov 23, 2022
@davetsay
Copy link
Contributor Author

davetsay commented Dec 5, 2022

Can't repro. Closing to retest.

Filing a somewhat related bughancement found during attempted repro. #6035

@davetsay davetsay closed this as not planned Won't fix, can't repro, duplicate, stale Dec 5, 2022
@unlikelyzero unlikelyzero added needs:e2e Needs an e2e test help_wanted Help the Open MCT project! and removed unverified bug:retest Retest without a specific milestone labels Dec 5, 2022
@unlikelyzero unlikelyzero added this to To triage in Improve Test Coverage via automation Dec 5, 2022
@ozyx
Copy link
Member

ozyx commented Dec 5, 2022

Unable to reproduce, Testathon 12/5/22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:regression It used to work. Now it doesn't :( help_wanted Help the Open MCT project! needs:e2e Needs an e2e test performance impacts or improves performance severity:medium type:bug
Projects
Time Conductor Refactor
Issues on current design
Development

No branches or pull requests

4 participants