Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional Set "output" is wrong #5918

Closed
2 of 7 tasks
charlesh88 opened this issue Oct 26, 2022 · 6 comments · Fixed by #6244
Closed
2 of 7 tasks

Conditional Set "output" is wrong #5918

charlesh88 opened this issue Oct 26, 2022 · 6 comments · Fixed by #6244

Comments

@charlesh88
Copy link
Contributor

charlesh88 commented Oct 26, 2022

Summary

When no data is present for telemetry in use by a Condition Set (CS), the set says it's outputting a default value (orange arrow), but it actually is not. Note that the Default condition is not hilited (green arrow).

Screen Shot 2022-10-26 at 4 09 33 PM

LAD Table view of the Condition set shows that no data is available:

Screen Shot 2022-10-26 at 4 18 50 PM

Adding the CS to a Display Layout as an alpha shows that no value is being output:

Screen Shot 2022-10-26 at 4 19 56 PM

Expected vs Current Behavior

The CS should not erroneously report an output value, but instead should be blank or "---". CS views currently only output a value when they have an input, such as data. This makes sense: the CS needs an input to determine its output frequency.

Related Issues

Steps to Reproduce

  1. Make or edit a CS and include one or more telemetry points that don't have any data currently. Give it at least one condition besides the default.
  2. Save the CS, then nav away and back.
  3. Observe: the CS reports an output of Default, but shouldn't.

Environment

  • Open MCT Version: 2.0.5, 2.1.2
  • Deployment Type: MMOC, /latest
  • OS: any
  • Browser: any

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

@shefalijoshi
Copy link
Contributor

@charlesh88
What is the expected behavior for the following scenarios?

  1. There is data for one or more conditions and the CS is working as expected highlighting the right condition, then the conditions with data incoming are deleted so that there are no more conditions with incoming data.
  2. There were previously conditions that have now all been removed (leaving only Default).
    Should we highlight Default in these cases? or Should we fall back to '---'/empty?

@shefalijoshi
Copy link
Contributor

Update with discussion:
The issue here is whether we should output anything at all if there is no input data/telemetry flowing into the condition set.
This discussion has not yet been closed.

@unlikelyzero unlikelyzero removed this from the Target:2.1.3 milestone Dec 27, 2022
@akhenry akhenry added this to the Target:2.1.6 milestone Jan 25, 2023
@scottbell scottbell self-assigned this Jan 26, 2023
@scottbell
Copy link
Contributor

I was able to reproduce it. Looking into it now:

Showing_Default.mov

@scottbell
Copy link
Contributor

@charlesh88 If you could please, let me know your thoughts on @shefalijoshi's scenarios. I'll look into the naive case first (no telemetry at all/ever).

@scottbell scottbell linked a pull request Feb 1, 2023 that will close this issue
15 tasks
@shefalijoshi
Copy link
Contributor

@charlesh88 , @scottbell and @shefalijoshi Talked about this and the short term solution is to change the output of the condition set view to ---

@akhenry akhenry modified the milestones: Target:2.1.6, Target:2.2.0 Feb 9, 2023
@charlesh88
Copy link
Contributor Author

charlesh88 commented Mar 6, 2023

Testing Notes

  1. Make or edit a CS and include one or more telemetry points that don't have any data currently, or that has no telemetry in it. Give it at least one condition besides the default.
  2. Save the CS and exit editing. Nav away and back to it and view it in browse mode.
  3. Verify that the CS reports "---" as its output, and is not matching the Default (or any other) condition.
  4. Use the Condition Set to conditionally style an element in a layout. Verify that after saving, navving away and back that the element is not using the Default style set by the CS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants