Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support requesting thumbnail-size images from the Imagery view #5931

Closed
akhenry opened this issue Oct 31, 2022 · 5 comments · Fixed by #6132
Closed

Support requesting thumbnail-size images from the Imagery view #5931

akhenry opened this issue Oct 31, 2022 · 5 comments · Fixed by #6132
Labels
needs:e2e Needs an e2e test type:feature Feature. Required intentional design
Milestone

Comments

@akhenry
Copy link
Contributor

akhenry commented Oct 31, 2022

Is your feature request related to a problem? Please describe.
In Open MCT images are currently defined by a URL, which either links to a file on a server, or includes a base-64 encoded image. There is a need to support requesting images at various scales (if the backend supports it). The imagery view should provide sufficient information to providers to allow them to make an intelligent decision about which scale to use when retrieving an image. Initially, let's focus on thumbnail images.

Thumbnail image are presented in the "filmstrip" view of image history shown at the bottom of the image view as in the example below.
Screen Shot 2022-10-31 at 11 57 20 AM

Describe the solution you'd like
One way of handling this is to pass an option with the request for historical imagery that designates that this is a "thumbnails" request. This would work like the "strategy" option we use for "latest" and "min-max" type requests in other places. eg.

const thumbnails = await openmct.telemetry.request(imageDomainObject, {scale: "thumbnail"});

Additional context
This will complement VIPEROMCT-208 which is exploring the use of an apache module for doing dynamic image resizing.

@akhenry akhenry added this to the 2.1.3 milestone Oct 31, 2022
@unlikelyzero unlikelyzero removed this from the Target:2.1.4 milestone Dec 29, 2022
@ozyx ozyx self-assigned this Jan 3, 2023
@ozyx ozyx added this to the Target:2.1.6 milestone Jan 3, 2023
@ozyx
Copy link
Member

ozyx commented Jan 21, 2023

Testing Instructions

  1. Create a new "Example Imagery" object
  2. Inspect one of the image thumbnails
  3. Verify that the thumbnail img src has url params "?w=100&h=100"
  4. Inspect the main image
  5. Verify that it does not contain the same url params
  6. Create a Time Strip
  7. Drag the Example Imagery into the time strip
  8. Hover over the timestrip or adjust bounds to show just a few images and inspect one of the image thumbnails
  9. Verify it has the same thumbnail url params
  10. Click on the image to "View Large"
  11. Inspect the main image, verify it does not have the thumbnail params
  12. Inspect the thumbnails, verify they do have the thumbnail params

@khalidadil
Copy link
Contributor

Verified Fixed in Testathon on 01/24/23

@unlikelyzero unlikelyzero added the type:feature Feature. Required intentional design label Jan 27, 2023
@unlikelyzero
Copy link
Collaborator

Need two more folks to test this after YAMCS upgrade

@khalidadil
Copy link
Contributor

Verified this again after yamcs upgrade - Testathon 02/06/23

@michaelrogers
Copy link
Contributor

Fix verified during testathon 02/06/2023 for example imagery.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:e2e Needs an e2e test type:feature Feature. Required intentional design
Projects
Development

Successfully merging a pull request may close this issue.

5 participants