Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Huge openmct.js bundle #6005

Closed
inad9300 opened this issue Nov 23, 2022 · 5 comments · Fixed by #6007
Closed

Huge openmct.js bundle #6005

inad9300 opened this issue Nov 23, 2022 · 5 comments · Fixed by #6007
Labels
type:maintenance tests, chores, or project maintenance
Milestone

Comments

@inad9300
Copy link

inad9300 commented Nov 23, 2022

After building OpenMCT for production, dist/openmct.js weights 24 MB. Is this expected? I am using the following Dockerfile:

FROM node:18.12.0-bullseye-slim

RUN apt-get update && apt-get install --yes --no-install-recommends git

# TODO: Any way to avoid this?
RUN git config --global http.sslVerify false

RUN cd /opt && git clone --depth 1 --branch v2.1.2 https://github.com/nasa/openmct.git

WORKDIR /opt/openmct
RUN npm install
@davetsay
Copy link
Contributor

Testing instructions

npm run clean
npm i
ls -ll dist/openmct.js

size should be < 5mb

@davetsay
Copy link
Contributor

@inad9300 , thanks for filing this issue. I have pushed a PR to fix this. Alternatively, to fix in previous branches/commits, change eval-source-map to a different or no source map strategy in webpack.prod.js.

@akhenry
Copy link
Contributor

akhenry commented Dec 5, 2022

Confirmed fixed. Nice work!

@akhenry akhenry removed the unverified label Dec 5, 2022
@unlikelyzero unlikelyzero added type:maintenance tests, chores, or project maintenance unverified and removed type:bug labels Dec 5, 2022
@unlikelyzero unlikelyzero added this to the Target:2.1.4 milestone Dec 5, 2022
@unlikelyzero
Copy link
Collaborator

Testing Notes

Validate that sourcemaps still work on viper deployments

@jvigliotta
Copy link
Contributor

Verified Fixed - Testathon 12/5/2022

Source maps be lookin' good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants