Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MultiYAxis] Activating Limit lines on a series fails #6106

Closed
3 of 7 tasks
ozyx opened this issue Jan 9, 2023 · 2 comments · Fixed by #6181
Closed
3 of 7 tasks

[MultiYAxis] Activating Limit lines on a series fails #6106

ozyx opened this issue Jan 9, 2023 · 2 comments · Fixed by #6181
Labels
bug:regression It used to work. Now it doesn't :( severity:blocker type:bug
Milestone

Comments

@ozyx
Copy link
Member

ozyx commented Jan 9, 2023

Summary

Expected vs Current Behavior

Limit lines should be able to be activated, settings should persist per series, and limit lines should be displayed correctly.

Steps to Reproduce

  1. Create an Overlay Plot
  2. Create a SIne Wave Generator
  3. Drag it into the Overlay Plot
  4. In Edit mode on the Overlay Plot, edit the series settings and activate "Limit Lines"
  5. Observe console errors
  6. Observe no limit lines appear
  7. Save, navigate away and back, edit again and notice the settings have not persisted

image

Environment

  • Open MCT Version: feature/plots-multiple-y-axes
  • Deployment Type: local
  • OS: MacOS
  • Browser: Chrome

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

@shefalijoshi
Copy link
Contributor

shefalijoshi commented Jan 25, 2023

Testing instructions:

  1. Create an overlay plot with multiple telemetry endpoints with different ranges and/or limits (For Sine Wave generators, use different offsets)
  2. Enable limit lines for all endpoints in the inspector properties
  3. Ensure that limit lines are drawn correctly and hovering over the legend shows limit values
  4. Move the telemetry endpoints between y axes
  5. Ensure that limit lines are drawn correctly and hovering over the legend shows limit values
    NOTE Depending on the telemetry endpoint, sometimes the limits might be outside the canvas and may not be drawn.

VIPER Deployment
Validate the above with the /ViperGround/Test/navcamPanAngle endpoint. Reach out to @unlikelyzero if you have additional problems

@unlikelyzero unlikelyzero added severity:blocker bug:regression It used to work. Now it doesn't :( labels Jan 27, 2023
@ozyx
Copy link
Member Author

ozyx commented Jan 31, 2023

Verified fixed Testathon 1-31-23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:regression It used to work. Now it doesn't :( severity:blocker type:bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants