Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable camera position and angle for Imagery compass rose #6139

Closed
charlesh88 opened this issue Jan 18, 2023 · 5 comments · Fixed by #6140
Closed

Configurable camera position and angle for Imagery compass rose #6139

charlesh88 opened this issue Jan 18, 2023 · 5 comments · Fixed by #6140
Labels
type:feature Feature. Required intentional design
Milestone

Comments

@charlesh88
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Current Imagery compass rose is limited to a single camera in one position relative to its equipment frame (spacecraft, rover, etc.).

Describe the solution you'd like
Support multiple cameras in different positions and angles relative to the equipment frame. Parameterize in such a way that multiple configurations are supported.

@charlesh88
Copy link
Contributor Author

charlesh88 commented Jan 18, 2023

Camera translate rotate deg scale
aft 0%, 21% 180 0.3
haz-port-aft 13%, 18% 90 0.3
haz-port-fwd -13%, 18% 90 0.3
haz-stbd-aft -13%, 18% 270 0.3
haz-stbd-fwd 13%, 18% 270 0.3
nav 0%, 18%   0.3

@akhenry akhenry added this to the Target:2.1.6 milestone Jan 20, 2023
@davetsay davetsay self-assigned this Jan 21, 2023
@charlesh88
Copy link
Contributor Author

charlesh88 commented Jan 24, 2023

Testing Notes

Go to an Imagery view with image data products available, like [ask someone]

  1. Verify that the compass rose appears similar to the reference examples below. Verify that the rover body is positioned and rotated as noted for each camera type.
  2. Click the compass rose and verify it toggles from FOV "up" to north up. Verify that that all elements rotate together as expected.

Navcam

The rover body's top center should be at the compass center, and can rotate around that point relative to the camera FOV to articulate the navcam gimbal value.
Screen Shot 2023-01-24 at 10 40 59 AM

Aftcam

The rover body's back center should be at the compass center, pointing 180 deg away from the FOV.
Screen Shot 2023-01-24 at 10 41 10 AM

Hazcams

Hazcams are placed over each wheel, facing out 90 deg to either port or starboard, with the rover body be placed accordingly.
Screen Shot 2023-01-24 at 10 40 44 AM
Screen Shot 2023-01-24 at 10 53 04 AM

@ozyx
Copy link
Member

ozyx commented Jan 24, 2023

Verified Fixed -- Testathon 1/24/23

@jvigliotta
Copy link
Contributor

Verified Fixed: Testathon - 1/24/23

@rukmini-bose
Copy link
Contributor

Verified Testathon 1/24/23

@unlikelyzero unlikelyzero added type:feature Feature. Required intentional design and removed type:enhancement unverified labels Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature Feature. Required intentional design
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants