Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotations on empty entries in notebook are lost #6156

Closed
2 tasks done
davetsay opened this issue Jan 23, 2023 · 5 comments · Fixed by #6525
Closed
2 tasks done

Annotations on empty entries in notebook are lost #6156

davetsay opened this issue Jan 23, 2023 · 5 comments · Fixed by #6525

Comments

@davetsay
Copy link
Contributor

Summary

Entries do not get persisted until text is entered. If you create a blank entry, then add an annotation/tag to it, then navigate away, the blank entry is removed and there is a misleading indication that the tag is attached to something.

Expected vs Current Behavior

Either the tag is also removed from view, or blank entries can be persisted. @charlesh88 , what say you?

Steps to Reproduce

  1. create and navigate to a notebook
  2. click + to add an entry
  3. click on the entry element
  4. click on the annotations tab in inspector
  5. add an annotation/tab
  6. observe the blank entry is removed from view and the tag in inspector is still displayed

Environment

  • Open MCT Version: master
  • Deployment Type:
  • OS:
  • Browser:

Impact Check List

  • Data loss or misrepresented data?
  • [] Regression? Did this used to work or has it always been broken?
  • [] Is there a workaround available?
  • [] Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • [] Does this block the execution of e2e tests?
  • [] Does this have an impact on Performance?

Additional Information

@ozyx ozyx added this to the Target:2.1.6 milestone Jan 24, 2023
@akhenry akhenry modified the milestones: Target:2.1.6, Target:2.2.0 Feb 6, 2023
@unlikelyzero unlikelyzero removed this from the Target:2.2.0 milestone Mar 15, 2023
@unlikelyzero
Copy link
Collaborator

@davetsay is this the same as #6411 ?

@scottbell scottbell self-assigned this Mar 30, 2023
@scottbell
Copy link
Contributor

@davetsay is this the same as #6411 ?

@unlikelyzero I think these are slightly different issues. One is you have to select an entry when creating a new one. The second is if you've made an entry without text, tag it, and click away, we delete the entry underneath it (and the tags now point to nothing).

@ozyx
Copy link
Member

ozyx commented Apr 17, 2023

Verified fixed -- Testathon 4-17-23

@khalidadil
Copy link
Contributor

Verified Fixed in Testathon on 04/17/23

@rukmini-bose
Copy link
Contributor

Verified Testathon 4/17/2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants