Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Overlay Plot] Turning off autoscale on a series causes it to not render on renavigate #6229

Closed
3 of 7 tasks
ozyx opened this issue Jan 31, 2023 · 4 comments · Fixed by #6258
Closed
3 of 7 tasks

[Overlay Plot] Turning off autoscale on a series causes it to not render on renavigate #6229

ozyx opened this issue Jan 31, 2023 · 4 comments · Fixed by #6258

Comments

@ozyx
Copy link
Member

ozyx commented Jan 31, 2023

Summary

Turning off autoscale on a plot series and then navigating away/back again causes the min and max values to become undefined and the series to not draw at all (no console errors observed). Entering a min and max value in the YAxis form and saving will then cause the series to redraw.

Expected vs Current Behavior

Turning off autoscale should persist its default min and max values on renavigate

Steps to Reproduce

  1. Create an Overlay Plot
  2. Drag an SWG into it
  3. Hit Edit
  4. Uncheck "autoscale"
  5. Observe min and max form fields have sensible defaults and plot series rerenders in the range
  6. Save
  7. Navigate away and back again
  8. Observe plot series is no longer rendered
  9. Hit edit
  10. Observe min and max are blank form fields

Environment

  • Open MCT Version: 2.1.6-SNAPSHOT
  • Deployment Type: local
  • OS: MacOS
  • Browser: Chrome

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

@ozyx
Copy link
Member Author

ozyx commented Feb 9, 2023

Testing notes

  1. Create an overlay plot
  2. Create 3 SWGs or drag 3 telemetry points into it
  3. Drag them to separate Y Axes, so 3 axes are shown
  4. Disable autoscale on the first y axis and set min and max
  5. Save
  6. Navigate away and back
  7. Verify plot series is still visible
  8. Repeat the same actions for the series on y axis 2 and 3

@ozyx ozyx added the unverified label Feb 9, 2023
@jvigliotta
Copy link
Contributor

Verified Fixed Testathon 2/9 I was ALL over the place. Looked good.

@khalidadil
Copy link
Contributor

Verified Fixed in Testathon on 02/09/23

@michaelrogers
Copy link
Contributor

Fix verified in testathon on 2023/02/09.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants