Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Overlay Plot] Turning on Log Mode and turning off Autoscale breaks the plot #6230

Closed
2 of 7 tasks
ozyx opened this issue Jan 31, 2023 · 4 comments
Closed
2 of 7 tasks

Comments

@ozyx
Copy link
Member

ozyx commented Jan 31, 2023

Summary

Turning off autoscale and turning on log mode for a plot series, saving, and then navigating away and back again breaks the plot completely and throws a bunch of console errors.

Expected vs Current Behavior

Log mode should be set and autoscale should be set with sensible defaults

Steps to Reproduce

  1. Create an Overlay Plot
  2. Drag an SWG into it
  3. Edit
  4. Turn off autoscale
  5. Observe sensible defaults populate the min and max fields
  6. Turn on log mode
  7. Observe the ticks change on the y axis
  8. Save
  9. Navigate away
  10. Navigate back
  11. See that the plot is completely broken, settings cannot be changed

Environment

  • Open MCT Version: 2.1.6-SNAPSHOT
  • Deployment Type: local
  • OS: MacOS
  • Browser: Chrome

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

image

Screen.Recording.2023-01-30.at.4.32.14.PM.mov
@ozyx
Copy link
Member Author

ozyx commented Feb 9, 2023

Testing Notes

  1. Create an Overlay Plot
  2. Drag an SWG into it
  3. Edit
  4. Turn off autoscale
  5. Observe fields are blank and an error is displayed. Leave them blank and ignore it.
  6. Turn on log mode
  7. Observe the ticks change on the y axis
  8. Save
  9. Navigate away
  10. Navigate back
  11. Verify that log mode is activated and the ticks reflect that
  12. Verify that Autoscale has reverted to being activated
  13. Turn off autoscale and set sensible min and max, notice the plot scale changes to reflect that.
  14. Try a few different min and max values, do some bounds testing here
  15. Save
  16. Navigate away, navigate back
  17. Confirm that plot series is still visible, plot scale is the same, log mode is still on

@michaelrogers
Copy link
Contributor

michaelrogers commented Feb 9, 2023

FIx verified during testathon on 2023/02/09. There are no errors when log mode is enabled and no min/max is set; as expected the plot reverts to autoscale. Additionally the min max scale values are persisted when they are set.

@rukmini-bose
Copy link
Contributor

Verified Testathon 2/9/23.

@khalidadil
Copy link
Contributor

Verified Fixed in Testathon on 02/09/23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants