Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot annotation key gesture is not working as expected/designed #6294

Closed
1 of 7 tasks
charlesh88 opened this issue Feb 6, 2023 · 4 comments · Fixed by #6377
Closed
1 of 7 tasks

Plot annotation key gesture is not working as expected/designed #6294

charlesh88 opened this issue Feb 6, 2023 · 4 comments · Fixed by #6377

Comments

@charlesh88
Copy link
Contributor

Summary

Alt-shift dragging in a plot is supposed to enable annotating the points of a plot by allowing a selection marquee. While a plot is in real-time mode and unpaused, alt-shift dragging zooms the view and pauses it. This is not expected and is inconsistent gesturally for the user.

Expected vs Current Behavior

What should be be done instead is this:

  • On mousedown, detect alt-shift being pressed.
  • Immediately pause the view, display orange border, etc. AND suppress zooming, allowing point selection to happen immediately.
  • The user will then manually have to unpause the plot when they've completed annotating; this is fine.

Steps to Reproduce

  1. TC in real-time mode, navigate to a plot view.
  2. Hold option (alt) and shift, then click and drag in the plot view.
  3. The view zooms as if doing a standard zoom, but should instead pause the view without zooming and allow annotation to occur.

Environment

  • Open MCT Version: 2.1.6-SNAPSHOT
  • Deployment Type: /testathon
  • OS:
  • Browser:

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

@unlikelyzero
Copy link
Collaborator

@scottbell it would be good to fix this when writing the e2e tests

@shefalijoshi
Copy link
Contributor

Possibly a dup of #6207

@unlikelyzero
Copy link
Collaborator

Testing notes

  • TC in real-time mode, navigate to a plot view.
  • Hold option (alt) and shift, then click and drag in the plot view.
  • The view zooms as if doing a standard zoom, but should instead pause the view without zooming and allow annotation to occur.

@jvigliotta
Copy link
Contributor

Verified Fixed - Testathon 3/9/23

Plot was paused, no zooming and I was able to add an annotation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants