[Staleness] Switching between clock modes incorrectly persists the current staleness state

[michaelrogers]

Relates to #6109

Summary

When staleness is currently visible in a component and the user switches clock modes, the staleness state is not cleared and persisted until new telemetry streams in.

Expected vs Current Behavior

Currently the staleness state is persisted between clock modes. Expected behavior is to clear the staleness state.

Steps to Reproduce

1. Setup a display layout containing SWG with staleness enabled
2. Wait until staleness is triggered ~10 seconds
3. Switch clock modes from Local to Remote
4. Observe the staleness styling is still present

Environment

• Open MCT Version:
• Deployment Type:
• OS:
• Browser:

Impact Check List

• Data loss or misrepresented data?
• Regression? Did this used to work or has it always been broken?
• Is there a workaround available?
• Does this impact a critical component?
• Is this just a visual bug with no functional impact?
• Does this block the execution of e2e tests?
• Does this have an impact on Performance?

Additional Information

[michaelrogers]

Screen.Recording.2023-02-13.at.4.56.12.PM.mov

[unlikelyzero]

Only a blocker if occurs between remote and fixed time

[khalidadil]

@shefalijoshi I'll have to work with you to figure out why this isn't working properly in remote clock - reopening

When following the reproduction steps, the staleness styling is persisting across local and remote clock for both SWG and the timely telemetry.

[khalidadil]

Note: Please use telemetry that has staleness when testing this (not an SWG).

[ozyx]

MOSTLY Verified. When switching while the components are stale, the staleness correctly clears on the objects but not on the parent:

This staleness state persists on the object view when switching objects, even to non-stale telemetry.

[ozyx]

Verified fixed -- 10/6/23

Steps:

1. Navigate to Flexible Layout full of telemetry which will go stale (timelyParameter) in local clock mode
2. Wait until staleness state is active
3. Navigate to the timelyParameter telemetry itself
4. Toggle to Remote Clock
5. The staleness state is cleared

The issue was that staleness styling was not being cleared on telemetry plot views