Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tabs] in eager load mode, only load the selected tab on tabs view load #6387

Closed
1 of 7 tasks
davetsay opened this issue Mar 2, 2023 · 3 comments · Fixed by #6424
Closed
1 of 7 tasks

[Tabs] in eager load mode, only load the selected tab on tabs view load #6387

davetsay opened this issue Mar 2, 2023 · 3 comments · Fixed by #6424

Comments

@davetsay
Copy link
Contributor

davetsay commented Mar 2, 2023

Summary

The tabs view remembers which tab was last selected. If the last selected tab is any tab besides the first, on load the tabs view will first load the first tab and then the last selected tab. This may be resolved by just implementing the fix for #4479.

Expected vs Current Behavior

Only the last selected tab should be loaded. Internally, this means views in tabs should not be destroyed

Steps to Reproduce

  1. Create a tabs view with Eager load tabs set to true
  2. drop telemetry into multiple tabs
  3. navigate to the tabs view
  4. select the last, right-most tab
  5. navigate away from tabs view
  6. open browser console and clear network requests
  7. navigate to the tabs view
  8. observe that telemetry requests will fire for the first tab twice when telemetry requests for each tab should only fire once
  9. tabs are traditionally brittle so regression testing with eager load = false is recommended

Environment

  • Open MCT Version:
  • Deployment Type:
  • OS:
  • Browser:

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

@davetsay
Copy link
Contributor Author

for testing instructions please see steps to reproduce in the description

@davetsay davetsay removed the needs:test instructions Missing testing notes label Mar 17, 2023
@ozyx
Copy link
Member

ozyx commented Mar 17, 2023

Verified fixed -- Testathon 3/17/2023 🍀

Tested in eager load mode. Requests were fired for each tab only once.
Tested in non-eager load mode. Requests were fired once for the currently selected tab.

@jvigliotta
Copy link
Contributor

Verified Fixed - Testathon 3/17/23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants