Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Greedy LAD] Have the ability to have data before the start bound IF it's a strategy 'latest' request #6449

Closed
jvigliotta opened this issue Mar 16, 2023 · 5 comments · Fixed by #6432
Labels
type:feature Feature. Required intentional design
Milestone

Comments

@jvigliotta
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Low frequency data in LAD views will have its values dropped as it ages out of the current time conductor window in real-time mode. While this is by design it can be counterintuitive.

Describe the solution you'd like
Would like to have LAD Views (strategy 'latest') requests hold onto older data outside of the start bound, if no other new data has come in, by default. Would also like the ability to turn this off.

@jvigliotta

This comment was marked as outdated.

@akhenry
Copy link
Contributor

akhenry commented Mar 17, 2023

Testing

  • Add ViperGround/OpenMCTTest/timelyParameter into a display layout
  • Add ViperGround/OpenMCTTest/timelyParameter into a LAD table, and then add that LAD table into the previous display layout
  • Switch to local clock
  • On banner, run -
cd /usr/local/viper/python-scripts
python send_low_frequency_parameter.py --apid=899 --interval=60
  • Set your time conductor to real-time mode, and only 30s of data
  • Verify that when telemetry ages out of the current time conductor bounds it does not disappear
  • Change the start bounds to 31s (assuming that the telemetry is now older than 31s)
  • Verify that both the LAD view and LAD table still show telemetry values for the timelyParameter, even though it is technically outside the conductor bounds.

@akhenry akhenry added this to the Target:2.2.0 milestone Mar 17, 2023
@akhenry
Copy link
Contributor

akhenry commented Mar 17, 2023

@unlikelyzero To verify

@unlikelyzero
Copy link
Collaborator

unlikelyzero commented Mar 18, 2023

I may misunderstand the testing instructions, but setting Time Conductor to:
Screen Shot 2023-03-17 at 5 13 15 PM

Instead of seeing MAD LAD Data in both the Table View and LAD View, the data is sometimes dropped from the Table View.
Screen Shot 2023-03-17 at 5 11 32 PM

@unlikelyzero unlikelyzero added type:feature Feature. Required intentional design and removed unverified type:enhancement labels Mar 31, 2023
@unlikelyzero
Copy link
Collaborator

working as designed. Need a release note

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature Feature. Required intentional design
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants