Duplicate Action does not work on some objects

[unlikelyzero]

Summary

Clone of VIPEROMCT-382

Some complex objects cannot be duplicated and instead throw an error in the console

Repro steps:

Navigate to https://#/browse/mine/e3d29a3a-08ff-4c7d-b32d-df130c2ebaef/87a24f2a-0011-4d08-8485-87505c3f4f5e?tc.mode=remote-clock&tc.startDelta=900000&tc.endDelta=15000&tc.timeSystem=utc&view=layout.view
Right click on the display in the tree and click on "Duplicate"
Attempt to duplicate the display into another folder
Note that nothing appears to happen in the UI, and the JavaScript console contains an error -

Uncaught (in promise) TypeError: Cannot convert undefined or null to object
    at hasOwnProperty (<anonymous>)
    at Object.eval (DuplicateTask.js:224:1)
    at JSON.parse (<anonymous>)
    at DuplicateTask.rewriteIdentifiers (DuplicateTask.js:222:1)
    at DuplicateTask.duplicateComposees (DuplicateTask.js:198:1)

Impact Check List

• Data loss or misrepresented data?
• Regression? Did this used to work or has it always been broken?
• Is there a workaround available?
• Does this impact a critical component?
• Is this just a visual bug with no functional impact?
• Does this block the execution of e2e tests?
• Does this have an impact on Performance?

[scottbell]

I'm having trouble replicating this, but the issue appears to be here in the reviver, where presumably it's being passed a null or undefined.

[scottbell]

With @unlikelyzero's help, I was able to replicate. The issue is in the layout, one of the items has a height & width with values of null. The duplicate action isn't checking for null or undefined before calling hasOwnProperty.

[scottbell]

It's the LineComponent's height and width that's the issue, and may be related to this.

[charlesh88]

Verified fixed Testathon 2023-08-23.

[khalidadil]

Verified Fixed in Testathon on 08/24/23. Was successfully able to clone the layout to another folder and did not see an error in the console.

[ozyx]

Verified fixed 8/24/23