Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest "ZIP" errors on npm install #7554

Closed
ozyx opened this issue Mar 5, 2024 Discussed in #7538 · 1 comment
Closed

Latest "ZIP" errors on npm install #7554

ozyx opened this issue Mar 5, 2024 Discussed in #7538 · 1 comment

Comments

@ozyx
Copy link
Member

ozyx commented Mar 5, 2024

Discussed in #7538

Originally posted by jtrack3d March 1, 2024
I noticed getting the latest ZIP, extract and npm install gives errors related to GIT.

Using a git clone -b v3.2.1 works.


@ozyx : Able to reproduce

npm WARN deprecated argv@0.0.2: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
npm WARN deprecated codecov@3.8.3: https://about.codecov.io/blog/codecov-uploader-deprecation-plan/

> openmct@4.0.0-next prepare
> npm run build:prod && npx tsc


> openmct@4.0.0-next build:prod
> webpack --config ./.webpack/webpack.prod.js

fatal: not a git repository (or any of the parent directories): .git
Error: Command failed: git rev-parse HEAD
fatal: not a git repository (or any of the parent directories): .git

    at checkExecSyncError (node:child_process:890:11)
    at execSync (node:child_process:962:15)
    at file:///some/path/to/openmct-master/.webpack/webpack.common.js:24:17
    at ModuleJob.run (node:internal/modules/esm/module_job:194:25) {
  status: 128,
  signal: null,
  output: [
    null,
    <Buffer >,
    <Buffer 66 61 74 61 6c 3a 20 6e 6f 74 20 61 20 67 69 74 20 72 65 70 6f 73 69 74 6f 72 79 20 28 6f 72 20 61 6e 79 20 6f 66 20 74 68 65 20 70 61 72 65 6e 74 20 ... 19 more bytes>
  ],
  pid: 96532,
  stdout: <Buffer >,
  stderr: <Buffer 66 61 74 61 6c 3a 20 6e 6f 74 20 61 20 67 69 74 20 72 65 70 6f 73 69 74 6f 72 79 20 28 6f 72 20 61 6e 79 20 6f 66 20 74 68 65 20 70 61 72 65 6e 74 20 ... 19 more bytes>
}
webpack compiled successfully

added 1061 packages, and audited 1062 packages in 2m

162 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities
@ozyx ozyx added needs:info Needs follow up or investigation severity:trivial and removed needs:info Needs follow up or investigation labels Mar 5, 2024
@ozyx
Copy link
Member Author

ozyx commented Mar 5, 2024

@jtrack3d:

Although the error messages look scary and say "fatal", this is actually just a warning. Open MCT will still build properly and start. The cause is that when downloading source as zip from GitHub, the .git folder, which we use to parse the build's branch and commit hash, is not included.

We should clean this up and make it clearer that it's only a warning and can be ignored (at the cost of build info on the "about" screen).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants