Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Examples] Modernize examples and document #846

Open
akhenry opened this issue Apr 22, 2016 · 7 comments
Open

[Examples] Modernize examples and document #846

akhenry opened this issue Apr 22, 2016 · 7 comments
Assignees

Comments

@akhenry
Copy link
Contributor

akhenry commented Apr 22, 2016

The examples should be as self-explanatory as possible. They are distinct from step-by-step tutorials in that they provide simple example code for common use cases, and as such should not require detailed explanation.

They do I think need a primer in each directory describing the purpose of the example. Wherever the code would benefit from inline comments to improve clarity this should also be added.

@akhenry akhenry added this to the Herbert milestone Apr 22, 2016
@akhenry akhenry self-assigned this Apr 22, 2016
@akhenry akhenry modified the milestones: Huxley, Herbert May 11, 2016
@akhenry akhenry removed this from the Huxley milestone May 26, 2016
@akhenry akhenry removed their assignment May 26, 2016
@akhenry akhenry added the help_wanted Help the Open MCT project! label May 26, 2016
@ghost
Copy link

ghost commented Aug 25, 2016

I can take this on as part of my learning process. Let me know if that's okay with you.

@VWoeltjen
Copy link
Contributor

It would definitely be helpful, but we're also in the midst of some API changes (#999 et al) which would render some of that work obsolete in a future release. A different help wanted issue might have more long-term value.

That said, if your motivation is to learn, that would be a good way to do so, and it would still be a great help for us (both to improve our documentation in the short-term, and to have a better starting point when transitioning the examples to the new API.)

So yes, definitely okay with us (and very much appreciated!), just with the caveats above.

@akhenry
Copy link
Contributor Author

akhenry commented Aug 25, 2016

@BogdanAlexandru If you do decide to take this on, there's a related issue to remove and reorganize some of the examples - #841. I'd suggest either taking that issue as well, or skipping the examples that are going to be removed.

And, thanks!

@VWoeltjen
Copy link
Contributor

For context, we plan to have the new API at release candidate status by end of September. (I realize "future release" above was rather vague and may have sounded farther-off.)

@wangsrc
Copy link

wangsrc commented Aug 26, 2016

why

@ghost
Copy link

ghost commented Aug 26, 2016

Thanks for the replies!

End of September is definitely soon enough; since this is my first contact I'm not sure how long it'd take until I'm comfortable enough to document everything, and I'm also not sure how long the review process will be until the result is up to par. So overall I feel the primers won't live long enough to be very useful.

Yeah, it's probably wiser to skip this one and learn without the overhead of the writing & PR.

@akhenry akhenry self-assigned this Sep 12, 2016
@larkin larkin changed the title [Examples] Examples are missing documentation [Examples] Modernize examples and document Sep 18, 2017
@larkin
Copy link
Contributor

larkin commented Sep 18, 2017

Have updated title, going to use this to track multiple topics related to examples. removing help-wanted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants