Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more debugging information for DISP-S1 triggering jobs #798

Open
hhlee445 opened this issue Apr 10, 2024 · 4 comments
Open

Add more debugging information for DISP-S1 triggering jobs #798

hhlee445 opened this issue Apr 10, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request must have needs triage Issue that requires triage pcm.r03-disp-s1

Comments

@hhlee445
Copy link
Contributor

Checked for duplicates

Yes - I've already checked

Alternatives considered

No - I haven't considered

Related problems

No response

Describe the feature request

We want to add following information to the logs for CSLC query/download jobs to trigger DISP-S1 sciflo jobs.

For a given query, what inputs were seen. We have this in GRQ, but I think having that in the logs would also be useful, especially if it’s easily searchable.
E.g. for the FWD queries, this would show the inputs with revision IDs in the query window.
For a given query, which Frame were considered (based on the inputs seen from the previous point)
Also list out which Frame were triggered for PGE jobs, along with the reason (e.g. 100% of bursts found, or X% bursts found, and we reached the wait time threshold)
Also list out which Frame were NOT triggered for PGE jobs, along with the reason
Reasons would include things like: “only x% bursts found (less than the X% threshold)“, or “x% of bursts found (surpassing X% threshold, but <100%), but waiting n more hours (out of N)“, etc.

@hhlee445 hhlee445 added enhancement New feature or request needs triage Issue that requires triage labels Apr 10, 2024
@hhlee445 hhlee445 added pcm.r03-dswx-s1 PCM Release 3 - DSWx-S1 must have labels Jun 18, 2024
@hhlee445 hhlee445 added pcm.r03-disp-s1 and removed pcm.r03-dswx-s1 PCM Release 3 - DSWx-S1 labels Jul 3, 2024
@philipjyoon
Copy link
Contributor

@sjlewis-jpl Do we also want the list of CSLC granules found for "k" purposes? For example, we if we processing with k=15, we will end up getting 27 * 15 CSLC granules from CMR. This would happen for every frame that we decide to trigger. Or do we want to suppress granules information for k purposes and print out granule information solely for ones that were being considered for triggering?

@sjlewis-jpl
Copy link
Contributor

Very good question Phil. We definitely want the list used when considering triggering, which I expect will allow us to more effectively debug issues with the trigger logic.

Getting all k dates for each burst recorded in the log... I'm not opposed to it, but it's not obvious to me how we will use that information. If you think it's useful, can we record it on a separate line or place from the list used to consider triggering? I think having easy access to those used for triggering will be important.

@philipjyoon
Copy link
Contributor

Steven, the current state of code is that the lower-level CMR code prints out every granule returned from CMR. k granules are retrieved from CMR the same way all granules are retrieved and therefore they are currently being output to the logs. And it looks very busy.

I've attached the current state of logs, this is using [k=4] let me know what you think.

@philipjyoon
Copy link
Contributor

DISP-S1-query-log-k4.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request must have needs triage Issue that requires triage pcm.r03-disp-s1
Projects
None yet
Development

No branches or pull requests

3 participants