Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coverage verification will fail if percentage is a round number #1143

Closed
skliper opened this issue Sep 7, 2021 · 0 comments · Fixed by #1144 or #1145
Closed

Coverage verification will fail if percentage is a round number #1143

skliper opened this issue Sep 7, 2021 · 0 comments · Fixed by #1144 or #1145
Labels
continuous-integration
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Sep 7, 2021

Is your feature request related to a problem? Please describe.
grep -oP "[1-9]+[0-9]*" will only find three matches for any percentage that ends with .0%, where 4 matches are expected.

Describe the solution you'd like
Change the first match to 0-9

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added this to the 6.0.0 milestone Sep 7, 2021
skliper added a commit to skliper/osal that referenced this issue Sep 7, 2021
@skliper
Fix nasa#1143, Regex update in coverage enforcement to match .0
5866acb
skliper added a commit to skliper/osal that referenced this issue Sep 7, 2021
@skliper
Fix nasa#1143, Regex update in coverage enforcement to match .0
e68c8a9
@skliper skliper mentioned this issue Sep 7, 2021
Merged
astrogeco added a commit that referenced this issue Sep 8, 2021
@astrogeco
Merge pull request #1144 from skliper/fix1143-cov_enforce_fix
b30de31 
Fix #1143, Regex update in coverage enforcement to match .0
@astrogeco astrogeco mentioned this issue Sep 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
continuous-integration
Projects
None yet
Milestone
Caelum
1 participant
@skliper