Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1193, Change format of UtAssert_StringBufCompare #1379

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thnkslprpt
Copy link
Contributor

@thnkslprpt thnkslprpt commented Mar 24, 2023

Checklist

Describe the contribution

An example:
Screenshot 2023-03-24 13 52 31

Testing performed
GitHub CI actions and local cFS test suite run all passing successfully.

Expected behavior changes
The change makes it easier to identify the discrepancy between the strings in case of a failed test.

Only slight downside is the increase in length of the test log... (each call to UtAssert_StringBufCompare() now results in 3 lines printed instead of 1).
There are currently ~40 uses of UtAssert_StringBufCompare() in cFE and OSAL.

Contributor Info
Avi Weiss @thnkslprpt

@github-advanced-security
Copy link

You have successfully added a new CppCheck configuration cppcheck. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@github-advanced-security
Copy link

You have successfully added a new CodeQL-coding-standard configuration coding-standard. As part of the setup process, we have scanned this repository and found 785 existing alerts. Please check the repository Security tab to see all alerts.

@github-advanced-security
Copy link

You have successfully added a new CodeQL-security configuration security. As part of the setup process, we have scanned this repository and found 4 existing alerts. Please check the repository Security tab to see all alerts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant