Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ToE Prediction Profile #91

Merged
merged 6 commits into from Nov 5, 2021
Merged

Add ToE Prediction Profile #91

merged 6 commits into from Nov 5, 2021

Conversation

teubert
Copy link
Collaborator

@teubert teubert commented Nov 4, 2021

Add new class for a ToE Prediction Profiles. These contain multiple predictions of Time of Event (ToE) including the time of prediction. To do this I leverage the built in class UserDict. The class acts like a dictionary, but is guaranteed to iterate in order of time of prediction (earliest prediction first).

This class will be used with the ToE profile metrics (e.g., Alpha-Beta)

Requirements for data structure:

  • Store time of prediction and ToE prediction
  • Ability to add new ToE predictions
  • Access will be in order of prediction time

@teubert teubert added the enhancement New feature or request label Nov 4, 2021
@teubert teubert added this to the v1.1 milestone Nov 4, 2021
@teubert teubert mentioned this pull request Nov 4, 2021
@GGorospe GGorospe self-assigned this Nov 5, 2021
Copy link
Collaborator

@GGorospe GGorospe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New addition of the ToE prediction storage in a dictionary structure looks like a good solution.

@teubert
Copy link
Collaborator Author

teubert commented Nov 5, 2021

Note for the record: /test-prog-models-released are expected to fail, as the dev branch of prog_algs is not compatible with the currently released version (i.e., they include breaking changes).

@teubert teubert merged commit 9afa650 into dev Nov 5, 2021
@teubert teubert deleted the feature/prediction_profile branch November 5, 2021 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants