Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 134 expand tests with output from subsetter #190

Conversation

danielfromearth
Copy link
Collaborator

@danielfromearth danielfromearth commented May 14, 2024

GitHub Issue: #134

Description

This change adds to the test suite an integration test, which requests and downloads subsetted TEMPO files from Harmony in Production, and then runs stitchee on the downloaded+subsetted files. A GitHub Actions workflow is also added to run the integration tests.

Local test steps

Ran the integration test function locally, and it passed.

Overview of integration done

[pending] pass the integration test in an automated GitHub Actions workflow run.

PR Acceptance Checklist

  • Unit tests added/updated and passing.
  • Integration testing
  • CHANGELOG.md updated
  • Documentation updated (if needed).

📚 Documentation preview 📚: https://stitchee--190.org.readthedocs.build/en/190/

@codecov-commenter
Copy link

codecov-commenter commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.84%. Comparing base (4640244) to head (2326fb3).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #190       +/-   ##
============================================
+ Coverage    11.95%   49.84%   +37.88%     
============================================
  Files           11       11               
  Lines          669      642       -27     
============================================
+ Hits            80      320      +240     
+ Misses         589      322      -267     
Flag Coverage Δ
integration 43.92% <0.00%> (?)
unittests 22.11% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielfromearth danielfromearth merged commit 6e2f8f3 into develop May 15, 2024
5 checks passed
@danielfromearth danielfromearth deleted the feature/issue-134-expand-tests-with-output-from-subsetter branch May 17, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expand test suite, including example output from subsetter
2 participants