-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/issue 134 expand tests with output from subsetter #190
Merged
danielfromearth
merged 27 commits into
develop
from
feature/issue-134-expand-tests-with-output-from-subsetter
May 15, 2024
Merged
Feature/issue 134 expand tests with output from subsetter #190
danielfromearth
merged 27 commits into
develop
from
feature/issue-134-expand-tests-with-output-from-subsetter
May 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #190 +/- ##
============================================
+ Coverage 11.95% 49.84% +37.88%
============================================
Files 11 11
Lines 669 642 -27
============================================
+ Hits 80 320 +240
+ Misses 589 322 -267
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…arate "tests/local" directory
danielfromearth
deleted the
feature/issue-134-expand-tests-with-output-from-subsetter
branch
May 17, 2024 17:47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: #134
Description
This change adds to the test suite an integration test, which requests and downloads subsetted TEMPO files from Harmony in Production, and then runs
stitchee
on the downloaded+subsetted files. A GitHub Actions workflow is also added to run the integration tests.Local test steps
Ran the integration test function locally, and it passed.
Overview of integration done
[pending] pass the integration test in an automated GitHub Actions workflow run.
PR Acceptance Checklist
CHANGELOG.md
updated📚 Documentation preview 📚: https://stitchee--190.org.readthedocs.build/en/190/