[WIP] Refactor all #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3 +/- ##
===========================================
+ Coverage 73.48% 83.98% +10.50%
===========================================
Files 32 7 -25
Lines 777 2036 +1259
===========================================
+ Hits 571 1710 +1139
- Misses 136 163 +27
- Partials 70 163 +93
Continue to review full report at Codecov.
|
nasa9084
force-pushed
the
refactor-all
branch
4 times, most recently
from
c48d1ff
to
95f049e
Compare
more impl add test for isOneOf add test for matchRuntimeExpr update ci go version fix to match to usecase trim double quote when it is string add testcases remove old testcase add testcases fix interfaces update goccy/go-yaml add testdata add an test with example add test case and fix yaml name add test cases add test cases add test for extension fix field name add test cases install reviewdog enable go mod remove unused regexp add test cases comment-out broken test the yaml example itself is broken check unknown key add log when generation normalize getter name skip generating inlined getter add validateURLTemplate add uspto example test rename tests upgrade go-yaml clean up rename test add test with api_with_examples.yaml wrap returning error remove unused code add test cases add test cases unuse %w verb fmt.Errorf go generate fix error test add test cases add test cases fix validation add testcases not check there cannot be unknown key add test cases add test cases add testcases update goccy/go-yaml add example test case add codecov config remove unreached code add test cases add test cases header.in and header.name must not be specified add testcases replace errors to Error add testcases add testcases do not check required parameter on reference object parse $ref in advance support inlined runtime expr key support string-embedded runtime expr rewrite IsRuntimeExpr add testcases add testcases add testcase add testcases fix type add testcases add testcases remove because PR#2042 is merged add testcases add testcases add testcases remove debug log add testcases add testcases rename test use ErrUnknownKey instead of errors.New define Is method for each error type make private concrete error types use ErrRequired instead of errors.New remove Is change to const add testcase set root document to each object ignore setroot_gen.go from coverage split generator add test fix url parse error message workaround: quote reference fix multiline string parsing fix error message on test update goccy/go-yaml quote when string string begin with # treated as string by quoting fix treating string bump go version in testing to 1.14.x move generator commands to internal package remove debug line add -show-src flag for generator commands encapsulate show-src flag into generator move travis ci to github actions fix typo update reviewdog and golangci-lint settings update reviewdog config change to use reviewdog/action-golangci-lint@v1 split github action delete codecov ignore rules define resolve remove unused .reviewdog.yml do not lint test files 2789-2831 lines are duplicate of `unmarshalyaml_test.go:2832-2874` (dupl) exclude unmarshalyaml_test.go from dupl
…its block (move short variable declaration to its own line if necessary) (golint)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #2