Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Push normalizing dictionary when training on a branch #308

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Push normalizing dictionary when training on a branch #308

merged 1 commit into from
Apr 18, 2023

Conversation

ivanzvonkov
Copy link
Collaborator

File with normalizing dict was only pushed when training off of the master branch.

@ivanzvonkov ivanzvonkov requested a review from bhyeh April 18, 2023 13:46
@ivanzvonkov ivanzvonkov mentioned this pull request Apr 18, 2023
Closed
bhyeh
bhyeh approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@bhyeh bhyeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see - LGTM!

@bhyeh bhyeh mentioned this pull request Apr 18, 2023
Merged
@ivanzvonkov ivanzvonkov merged commit 4b9b2a1 into master Apr 18, 2023
7 checks passed
@ivanzvonkov ivanzvonkov deleted the fix-normalizing-dict-update branch April 18, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhyeh bhyeh bhyeh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ivanzvonkov @bhyeh