-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exporter demo notebook + version bump + automate pypi release #77
Conversation
ivanzvonkov
commented
Mar 14, 2022
•
edited
Loading
edited
- Adds notebook to serve as documentation for exporter and address Documentation / Tutorial for using exporter #73
- Updates version and automates pypi release when a tag is added to master branch (may need more testing once merged)
- Also adds an action for manual test-pypi releases (before the tag on master should be made)
check_ee: bool = True, | ||
check_gcp: bool = True, | ||
check_ee: bool = False, | ||
check_gcp: bool = False, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
False defaults make more sense
@@ -15,7 +15,7 @@ | |||
author="Gabriel Tseng", | |||
author_email="gabrieltseng95@gmail.com", | |||
url="https://github.com/nasaharvest/cropharvest", | |||
version="0.2.0", | |||
version="0.3.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reasoned that the inference class update necessitates a whole minor version update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. automated deployments will be awesome; thanks!