Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo notebook accessible on colab #94

Merged
merged 1 commit into from
Jul 22, 2022
Merged

Demo notebook accessible on colab #94

merged 1 commit into from
Jul 22, 2022

Conversation

ivanzvonkov
Copy link
Contributor

@ivanzvonkov ivanzvonkov commented Jul 7, 2022

While testing a new release of CropHarvest I found that downloading the dataset now works on Google Colab.

This PR makes the demo notebook accessible through Colab, clears notebook outputs to allow opening a clean notebook, and adds assert statements to the notebook to make it easier to test new releases.

The Open in Colab button in the README.md references the notebook in the main branch which won't be updated until this PR is merged. Here's a button to run the notebook in this branch Open In Colab

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@gabrieltseng
Copy link
Collaborator

LGTM!

A thought I had is that we may want a default data dir within the package, so that you could call:

evaluation_datasets = CropHarvest.create_benchmark_datasets()

and if you don't care about where the data is stored, it stores it within the package (similar to how torchvision does it).

But that would be a seperate PR / discussion.

@ivanzvonkov ivanzvonkov merged commit 7104e9e into main Jul 22, 2022
@ivanzvonkov ivanzvonkov deleted the colab-demo branch July 22, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants