Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comprehensive fillna #109

Merged
merged 5 commits into from
Oct 3, 2022
Merged

Comprehensive fillna #109

merged 5 commits into from
Oct 3, 2022

Conversation

ivanzvonkov
Copy link
Contributor

@ivanzvonkov ivanzvonkov commented Sep 24, 2022

Issue:
Inference fails when the input tif file contains a band that has all nan values (with the exception of slope).

This is a prerequisite for making the next Hawaii map.

Additionally, the current solution used to fill nan slope values requires passing the mean slope value in functions such as process_test_file and _find_matching_point where the mean slope is not relevant.

Code changes:

  • A more general fillna function which fills nan values for all scenarios (see tests)
  • Implementation is simplified by applying fillna immediately after loading the tif file
  • The not so robust regex start date extraction is removed since it is no longer absolutely necessary for loading tifs

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ivanzvonkov ivanzvonkov changed the base branch from main to merging-script September 24, 2022 22:02
Copy link
Contributor

@gabrieltseng gabrieltseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing this at tif loading time is so much cleaner

Base automatically changed from merging-script to main October 3, 2022 13:51
@ivanzvonkov ivanzvonkov merged commit 61dad07 into main Oct 3, 2022
@ivanzvonkov ivanzvonkov deleted the comprehensive-fillna branch October 3, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants