Remove dyn-let as discussed in issue #139. #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyruseuros
added a commit
to cyruseuros/spacemacs
that referenced
this pull request
May 19, 2019
…yer. Currently, the theme also modifies `spacemacs-dark` if also loaded in `dotspacemacs-themes`. A [fix](nashamri/spacemacs-theme#144) for this is on it's way upstream to `spacemacs-theme`, but the maintainer already gave their [blessing](nashamri/spacemacs-theme#139).
cyruseuros
added a commit
to cyruseuros/spacemacs
that referenced
this pull request
May 19, 2019
…yer. Currently, the theme also modifies `spacemacs-dark` if also loaded in `dotspacemacs-themes`. A [fix](nashamri/spacemacs-theme#144) for this is on it's way upstream to `spacemacs-theme`, but the maintainer already gave their [blessing](nashamri/spacemacs-theme#139).
|
@nashamri any updates on this? |
|
@jjzmajic hey there, thank you and @noctuid so much for this. I think that macro was causing issues more than it solves. I did test this a couple of days ago and it seems to be working. I just need a bit of time to make sure everything is okay. 💜 |
|
Brilliant, thank you again @jjzmajic 👍 |
cyruseuros
added a commit
to cyruseuros/spacemacs
that referenced
this pull request
Aug 7, 2019
…yer. Currently, the theme also modifies `spacemacs-dark` if also loaded in `dotspacemacs-themes`. A [fix](nashamri/spacemacs-theme#144) for this is on it's way upstream to `spacemacs-theme`, but the maintainer already gave their [blessing](nashamri/spacemacs-theme#139).
smile13241324
pushed a commit
to syl20bnr/spacemacs
that referenced
this pull request
Aug 16, 2019
…yer. Currently, the theme also modifies `spacemacs-dark` if also loaded in `dotspacemacs-themes`. A [fix](nashamri/spacemacs-theme#144) for this is on it's way upstream to `spacemacs-theme`, but the maintainer already gave their [blessing](nashamri/spacemacs-theme#139).
stephanschubert
pushed a commit
to stephanschubert/spacemacs
that referenced
this pull request
Oct 23, 2019
…yer. Currently, the theme also modifies `spacemacs-dark` if also loaded in `dotspacemacs-themes`. A [fix](nashamri/spacemacs-theme#144) for this is on it's way upstream to `spacemacs-theme`, but the maintainer already gave their [blessing](nashamri/spacemacs-theme#139).
sei40kr
pushed a commit
to sei40kr/spacemacs
that referenced
this pull request
Nov 11, 2019
…yer. Currently, the theme also modifies `spacemacs-dark` if also loaded in `dotspacemacs-themes`. A [fix](nashamri/spacemacs-theme#144) for this is on it's way upstream to `spacemacs-theme`, but the maintainer already gave their [blessing](nashamri/spacemacs-theme#139).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#139