add test on bug and refactoring

app/controllers/web/social_networks_controller.rb

@@ -4,7 +4,14 @@ def facebook
 
     authorization = Authorization.find_by_provider_and_uid(auth_hash[:provider], auth_hash[:uid])
 
-    if authorization && !authorization.user.inactive?
+    if authorization
+
+      if authorization.user.inactive?
+        flash_error
+        redirect_to root_path
+        return
+      end
+
       sign_in authorization.user
       flash_success
     else

test/functional/web/social_networks_controller_test.rb

@@ -21,6 +21,18 @@ class Web::SocialNetworksControllerTest < ActionController::TestCase
     assert_equal current_user, @user
   end
 
+  test "should fail authorization with facebook" do
+    @user.deactivate
+    @user.authorizations << build_authorization(@auth_hash)
+    @user.save
+
+    request.env['omniauth.auth'] = @auth_hash
+    get :facebook
+
+    assert_response :redirect
+    assert !signed_in?
+  end
+
   test "should get authorization with facebook on existing user" do
     @user.email = @auth_hash[:info][:email] 
     @user.save
@@ -43,6 +55,20 @@ class Web::SocialNetworksControllerTest < ActionController::TestCase
     assert session_auth_hash
   end
 
+  test "should fail authorization with facebook on inactive user" do
+    @user.email = @auth_hash[:info][:email]
+    @user.deactivate
+
+    request.env['omniauth.auth'] = @auth_hash
+    get :facebook
+
+    assert_response :redirect
+    @user.reload
+    assert @user.inactive?
+    assert !signed_in?
+  end
+
+
   test "should get save auth_hash to session " do
     @user.activate
     sign_in @user