🐛 Source Close.com: extend roles schema with missing properties (ai…

…rbytehq#25868)
natalia-miinto · Jun 8, 2023 · 5102889 · 5102889
1 parent 8439924
commit 5102889
Show file tree

Hide file tree

Showing 11 changed files with 108 additions and 101 deletions.
diff --git a/airbyte-config-oss/init-oss/src/main/resources/seed/oss_catalog.json b/airbyte-config-oss/init-oss/src/main/resources/seed/oss_catalog.json
@@ -10775,7 +10775,7 @@
     "sourceDefinitionId": "dfffecb7-9a13-43e9-acdc-b92af7997ca9",
     "name": "Close.com",
     "dockerRepository": "airbyte/source-close-com",
-    "dockerImageTag": "0.2.1",
+    "dockerImageTag": "0.2.2",
     "documentationUrl": "https://docs.airbyte.com/integrations/sources/close-com",
     "icon": "close.svg",
     "sourceType": "api",

diff --git a/airbyte-config-oss/init-oss/src/main/resources/seed/source_definitions.yaml b/airbyte-config-oss/init-oss/src/main/resources/seed/source_definitions.yaml
@@ -325,7 +325,7 @@
 - name: Close.com
   sourceDefinitionId: dfffecb7-9a13-43e9-acdc-b92af7997ca9
   dockerRepository: airbyte/source-close-com
-  dockerImageTag: 0.2.1
+  dockerImageTag: 0.2.2
   documentationUrl: https://docs.airbyte.com/integrations/sources/close-com
   icon: close.svg
   sourceType: api

diff --git a/airbyte-config-oss/init-oss/src/main/resources/seed/source_specs.yaml b/airbyte-config-oss/init-oss/src/main/resources/seed/source_specs.yaml
@@ -2727,7 +2727,7 @@
     supportsNormalization: false
     supportsDBT: false
     supported_destination_sync_modes: []
-- dockerImage: "airbyte/source-close-com:0.2.1"
+- dockerImage: "airbyte/source-close-com:0.2.2"
   spec:
     documentationUrl: "https://docs.airbyte.com/integrations/sources/close-com"
     connectionSpecification:

diff --git a/airbyte-integrations/connectors/source-close-com/Dockerfile b/airbyte-integrations/connectors/source-close-com/Dockerfile
@@ -12,5 +12,5 @@ RUN pip install .
 ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
 ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]
 
-LABEL io.airbyte.version=0.2.1
+LABEL io.airbyte.version=0.2.2
 LABEL io.airbyte.name=airbyte/source-close-com
diff --git a/airbyte-integrations/connectors/source-close-com/acceptance-test-config.yml b/airbyte-integrations/connectors/source-close-com/acceptance-test-config.yml
@@ -14,12 +14,6 @@ acceptance_tests:
   discovery:
     tests:
     - config_path: "secrets/config.json"
-        # Some field types was changed for streams.
-        # custom_activities: id field was added
-        # custom_email_connected_accounts: imap field was changed to object
-        # smart_views: imap field was changed to object
-      backward_compatibility_tests_config:
-        disable_for_version: "0.1.0"
   basic_read:
     tests:
     - config_path: "secrets/config.json"

diff --git a/airbyte-integrations/connectors/source-close-com/integration_tests/expected_records.jsonl b/airbyte-integrations/connectors/source-close-com/integration_tests/expected_records.jsonl
diff --git a/airbyte-integrations/connectors/source-close-com/metadata.yaml b/airbyte-integrations/connectors/source-close-com/metadata.yaml
@@ -5,7 +5,7 @@ data:
   connectorSubtype: api
   connectorType: source
   definitionId: dfffecb7-9a13-43e9-acdc-b92af7997ca9
-  dockerImageTag: 0.2.1
+  dockerImageTag: 0.2.2
   dockerRepository: airbyte/source-close-com
   githubIssueLabel: source-close-com
   icon: close.svg

diff --git a/airbyte-integrations/connectors/source-close-com/source_close_com/schemas/contacts.json b/airbyte-integrations/connectors/source-close-com/source_close_com/schemas/contacts.json
@@ -1,5 +1,6 @@
 {
   "type": ["null", "object"],
+  "additionalProperties": true,
   "properties": {
     "phones": {
       "type": ["null", "array"],

diff --git a/airbyte-integrations/connectors/source-close-com/source_close_com/schemas/roles.json b/airbyte-integrations/connectors/source-close-com/source_close_com/schemas/roles.json
@@ -21,6 +21,15 @@
     },
     "permissions": {
       "type": ["null", "array"]
+    },
+    "visibility_user_lcf_behavior": {
+      "type": ["null", "string"]
+    },
+    "visibility_user_lcf_ids": {
+      "type": ["null", "array"],
+      "items": {
+        "type": ["null", "string"]
+      }
     }
   }
 }
diff --git a/airbyte-integrations/connectors/source-close-com/source_close_com/source.py b/airbyte-integrations/connectors/source-close-com/source_close_com/source.py
@@ -14,12 +14,14 @@
 from airbyte_cdk.sources.streams import Stream
 from airbyte_cdk.sources.streams.http import HttpStream
 from airbyte_cdk.sources.streams.http.auth import TokenAuthenticator
+from airbyte_cdk.sources.utils.transform import TransformConfig, TypeTransformer
 
 
 class CloseComStream(HttpStream, ABC):
     url_base: str = "https://api.close.com/api/v1/"
     primary_key: str = "id"
     number_of_items_per_page = None
+    transformer: TypeTransformer = TypeTransformer(TransformConfig.DefaultSchemaNormalization)
 
     def __init__(self, **kwargs: Mapping[str, Any]):
         super().__init__(authenticator=kwargs["authenticator"])

diff --git a/docs/integrations/sources/close-com.md b/docs/integrations/sources/close-com.md
@@ -89,6 +89,7 @@ The Close.com Connector has rate limit. There are 60 RPS for Organizations. You
 
 | Version | Date | Pull Request | Subject |
 | :--- | :--- | :--- | :--- |
+| 0.2.2 | 2023-05-05 | [25868](https://github.com/airbytehq/airbyte/pull/25868) | Added `CDK TypeTransformer` to gurantee JSON Schema types, added missing properties for `roles` stream |
 | 0.2.1 | 2023-02-15 | [23074](https://github.com/airbytehq/airbyte/pull/23074) | Specified date formatting in specification |
 | 0.2.0 | 2022-11-04 | [18968](https://github.com/airbytehq/airbyte/pull/18968) | Migrate to Low-Code |
 | 0.1.0 | 2021-08-10 | [5366](https://github.com/airbytehq/airbyte/pull/5366) | Initial release of Close.com connector for Airbyte |