-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating arucov3 #93
Merged
Merged
Updating arucov3 #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added additional FindXXX.cmake necessary to build modules with G2O dependencies.
Updated instantiation of G2O solvers, block solvers and optimizers. Code is compiling but crashes when optimization is being called.
This flag may be conflicting with PCL compilation flags, which can cause runtime errors on RANSAC::compute() method.
…olver.cpp This instance is a singleton and is already declared in event_logger.cpp (the only code that must retrieve a reference to the instance are user code e.g. code in int main(..) function).
…on_types.h) With these changes, RGB-D RTK is built using the same compilation flags used to build PCL; also, EIGEN_MAKE_ALIGNED_OPERATOR_NEW was added to structs in the common module.
This was referenced Nov 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
**************** NEEDS TO BE ACCEPTED AFTER NEW-SLAM-SOLVER BRANCH MERGE **************
Updating Aruco version.
There wasn't any issue with the code used by Aruco 2