Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prefix for resources #160

Closed
RocketRider opened this issue Feb 22, 2018 · 4 comments
Closed

Add prefix for resources #160

RocketRider opened this issue Feb 22, 2018 · 4 comments

Comments

@RocketRider
Copy link
Contributor

The resources "surface_view.xml" and "texture_view.xml" are very generic names and maybe are used by the app or an other library. This could lead to mix up of these resources.
So it is recommended to prefix library resources.

https://medium.com/@maxirosson/how-to-improve-your-android-library-2e8b9fd6c090
@natario1
Copy link
Owner

Right. Could you do this?

RocketRider pushed a commit to RocketRider/CameraView that referenced this issue Feb 22, 2018
natario1#160 Add prefix for resources
55f4556
@RocketRider
Copy link
Contributor Author

Made a pull request

@natario1
Copy link
Owner

Cool! Let's wait for Travis

natario1 pushed a commit that referenced this issue Feb 22, 2018
@RocketRider @natario1
#160 Add prefix for resources (#162)
9bb5a7c
@natario1
Copy link
Owner

Thanks!

@lancewoo lancewoo mentioned this issue Dec 25, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RocketRider @natario1