add missing invalidate call #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What happens if you call just awakenScrollBars() but before all the rest, right after matrix.set()? |
|
Tried it didn't work. We can test though if vertical and/or horizontal scrollbar is enabled if you want. |
|
The problem is awakenScrollbars does nothing if fadeScrollbars is set to false. I don't know why the child views are rendered and the scrollbars are not, but the additional invalidate fixes it. If you know a better solution let me know. |
|
Yeah this is confusing, but let's do it this way then 👍thanks for spotting this! |
markusressel
added a commit
that referenced
this pull request
Dec 26, 2018
* add missing invalidate call * added check if scrollbar is enabled (at least in one direction)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes #34