Fixes view offset on Android 6 and lower #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay. I think this makes sense, thank you! |
natario1
approved these changes
Dec 12, 2018
This was referenced Dec 12, 2018
markusressel
pushed a commit
that referenced
this pull request
Dec 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the view offset on Android 6 and lower. If the ZoomLayout has no clickable children the child is moved to the top of the screen . It seems like the views matrix is already translated in the lower versions and overriding it with a different one removes the inital translation. (Altough the views matrix says it's an identiy matrix). This behavior can be seen in the issues #32 and #22 or simply by setting the
hasClickableChildrento false in the sample.