-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exomast Retrieval #37
Exomast Retrieval #37
Conversation
@nespinoza, just so you can see the progress |
I just checked out your pull request and although the button is now there, it doesn't look like the button has an action paired to it. So naturally, it breaks. What is the expected behavior of your pull request?? It would be better to only submit pull requests for complete features (unless I am missing something, in which case apologies!!!). |
Currently running the tool, I type a planet name in say, |
Upon "resolve target" I get:
And no changes are made to the html page. |
@natashabatalha ah ha. It's because I am running in |
@natashabatalha okay, so I needed to add a return before rendering the html. I also added the semi-major axis to the retrieval. It should work now, let me know (fingers crossed). |
…f the source code. html for resolver isnt the prettiest but we are getting closer. Submitting the form and parameter retrieval are two different processes now and there is some duplicate code floating around that will need to be cleaned up
…anets argument to the render method for HST
Fixed exomast retrieval for HST and JWST
Hey @natashabatalha! This PR is ready for review now. @nespinoza and I have made some pretty significant changes to the UI and some smaller changes to the back end. Reach out if you have questions and we are hoping to hear from you soon! |
@mfixstsci great work! All looks good. My one comment is the https://natashabatalha.github.io/PandExo/tutorialjwst.html#setting-up-a-run The |
@mfixstsci oh and one last comment! I ended up pushing your changes directly to master. For the next PR, let's branch/merge those off of |
Pushing UI changes and some backend changes. Need to parse the result of ExoMAST retrieval back into
newHST
form.