Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exomast Retrieval #37

Merged
merged 17 commits into from
Aug 24, 2020
Merged

Conversation

mfixstsci
Copy link
Contributor

Pushing UI changes and some backend changes. Need to parse the result of ExoMAST retrieval back into newHST form.

@mfixstsci
Copy link
Contributor Author

@bourque

@mfixstsci
Copy link
Contributor Author

@nespinoza, just so you can see the progress

@natashabatalha
Copy link
Owner

natashabatalha commented Mar 11, 2020

I just checked out your pull request and although the button is now there, it doesn't look like the button has an action paired to it. So naturally, it breaks. What is the expected behavior of your pull request?? It would be better to only submit pull requests for complete features (unless I am missing something, in which case apologies!!!).

@mfixstsci
Copy link
Contributor Author

Currently running the tool, I type a planet name in say, wasp19b and then click resolve target. The page reloads and all of the parameters are loaded in the user defined properties section.

@natashabatalha
Copy link
Owner

Upon "resolve target" I get:

HTTPServerRequest(protocol='http', host='localhost:1111', method='POST', uri='/calculation/newHST', version='HTTP/1.1', remote_ip='::1') Traceback (most recent call last): File "/Users/nbatalh1/.conda/envs/pandexo/lib/python3.7/site-packages/tornado/web.py", line 1697, in _execute result = method(*self.path_args, **self.path_kwargs) File "/Users/nbatalh1/Documents/codes/PandExo/pandexo/engine/run_online.py", line 609, in post fileinfo_plan = self.request.files['planFile'][0] KeyError: 'planFile'

And no changes are made to the html page.

@mfixstsci
Copy link
Contributor Author

@natashabatalha ah ha. It's because I am running in debug = True. Let me trying something that I just thought of and see if it works.

@mfixstsci
Copy link
Contributor Author

@natashabatalha okay, so I needed to add a return before rendering the html. I also added the semi-major axis to the retrieval. It should work now, let me know (fingers crossed).

pandexo/engine/run_online.py Outdated Show resolved Hide resolved
@mfixstsci mfixstsci changed the title WIP: Exomast Retrieval Exomast Retrieval Aug 24, 2020
@mfixstsci
Copy link
Contributor Author

Hey @natashabatalha! This PR is ready for review now. @nespinoza and I have made some pretty significant changes to the UI and some smaller changes to the back end. Reach out if you have questions and we are hoping to hear from you soon!

@natashabatalha natashabatalha merged commit 199f966 into natashabatalha:master Aug 24, 2020
@natashabatalha
Copy link
Owner

@mfixstsci great work! All looks good. My one comment is the exo_input.json get's printed out for the user to explore all inputs :

https://natashabatalha.github.io/PandExo/tutorialjwst.html#setting-up-a-run

The url and url_err is more of a backend thing that should be entirely hidden from the UI. I left it in there for this round, but be cognizant of that for future inserts. If more keys need to be added, we should create a separate online_config.json, for instance.

@natashabatalha
Copy link
Owner

@mfixstsci oh and one last comment! I ended up pushing your changes directly to master. For the next PR, let's branch/merge those off of dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants