Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update InVEST to use new d8 stream 'extraction' function #1143

Closed
phargogh opened this issue Jan 4, 2023 · 1 comment · Fixed by #1145
Closed

Update InVEST to use new d8 stream 'extraction' function #1143

phargogh opened this issue Jan 4, 2023 · 1 comment · Fixed by #1145
Assignees
@phargogh
Labels
task Something needs to be done
Milestone
3.13.0

Comments

@phargogh
Copy link
Member

phargogh commented Jan 4, 2023

In natcap/pygeoprocessing#272, to be released in pygeoprocessing 2.4.0 we added a function to 'extract' streams based on d8 flow accumulation. As mentioned in the original issue, there are a couple of known places where we use a function like this:

https://github.com/natcap/invest/blob/main/src/natcap/invest/delineateit/delineateit.py#L299
https://github.com/natcap/invest/blob/main/src/natcap/invest/routedem.py#L125

NDR, SDR, SWY use MFD and so are using the MFD stream extraction function.
@phargogh phargogh added the enhancement New feature or request label Jan 4, 2023
@phargogh phargogh added this to the 3.13.0 milestone Jan 4, 2023
@phargogh phargogh self-assigned this Jan 4, 2023
@phargogh phargogh added task Something needs to be done and removed enhancement New feature or request labels Jan 4, 2023
phargogh added a commit to phargogh/invest that referenced this issue Jan 5, 2023
@phargogh
Updating delineateit to use the new streams function.
77e7a67 
RE:natcap#1143
phargogh added a commit to phargogh/invest that referenced this issue Jan 5, 2023
@phargogh
Updating routedem to use new stream extraction function.
7106c81 
RE:natcap#1143
phargogh added a commit to phargogh/invest that referenced this issue Jan 5, 2023
@phargogh
Bumping pygeoprocessing requirement in anticipation of release.
54f086b 
RE:natcap#1143
phargogh added a commit to phargogh/invest that referenced this issue Jan 5, 2023
@phargogh
Noting change in HISTORY.
549c16e 
RE:natcap#1143
@phargogh phargogh mentioned this issue Jan 5, 2023
Merged
1 task
@phargogh
Copy link
Member Author

phargogh commented Mar 9, 2023

Resolved in #1145

@phargogh phargogh closed this as completed Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phargogh phargogh

Labels
task Something needs to be done
Projects
None yet
Milestone
3.13.0
Development

Successfully merging a pull request may close this issue.

Use D8 stream extraction phargogh/invest
1 participant
@phargogh