Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REC: polygon area metrics overcount when polygons overlap #1310

Closed
davemfish opened this issue May 10, 2023 · 0 comments · Fixed by #1341
Closed

REC: polygon area metrics overcount when polygons overlap #1310

davemfish opened this issue May 10, 2023 · 0 comments · Fixed by #1341
Assignees
Labels
bug Something isn't working in progress This issue is actively being worked on
Milestone

Comments

@davemfish
Copy link
Contributor

For predictor methods polygon_area_coverage and polygon_percent_coverage, the predictor polygons are intersected with the AOI polygons and the area of the predictor intersection is summed. If the predictor layer includes overlapping polygons, then the area of the overlap is counted once for each polygon. This results in incorrect computed areas, which only really become noticeable when the value is greater than the area of the AOI cell (or percentages over 100).

I can't think of any reason why overlapping polygons should be double-counted like this. I think both of these metrics imply that it is the union of the predictor polygons that matters in terms of assessing its spatial coverage. So we should probably do that union before computing areas.

@davemfish davemfish added the bug Something isn't working label May 10, 2023
@davemfish davemfish added this to the 3.13.1 milestone May 10, 2023
@davemfish davemfish self-assigned this Jun 26, 2023
@davemfish davemfish added the in progress This issue is actively being worked on label Jun 26, 2023
davemfish added a commit to davemfish/invest that referenced this issue Jun 26, 2023
davemfish added a commit to davemfish/invest that referenced this issue Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in progress This issue is actively being worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant