Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NDR use of cutline is intolerant of minor geometry issues #1412

Closed
phargogh opened this issue Sep 15, 2023 · 0 comments · Fixed by #1427
Closed

NDR use of cutline is intolerant of minor geometry issues #1412

phargogh opened this issue Sep 15, 2023 · 0 comments · Fixed by #1427
Assignees
@phargogh
Labels
bug Something isn't working in progress This issue is actively being worked on

Comments

@phargogh
Copy link
Member

We had a recent issue on the forums where the issue was that the user had 3 ring self-intersections (see below) that were causing the cutline option to gdal.Warp to fail due to invalid geometry.

Screenshot 2023-09-15 at 11 47 27 AM

Years ago we removed the cutline functionality from pygeoprocessing.warp_raster because of its fragility, so I think we should refactor these masking function calls to either use pygeoprocessing.mask_raster, or a combination of rasterize and raster_map.
@phargogh phargogh added bug Something isn't working in progress This issue is actively being worked on labels Sep 15, 2023
@phargogh phargogh self-assigned this Sep 15, 2023
phargogh added a commit to phargogh/invest that referenced this issue Oct 6, 2023
@phargogh
Reimplementing cutline with raster_calculator.
3c27ade 
RE:natcap#1412.
phargogh added a commit to phargogh/invest that referenced this issue Oct 6, 2023
@phargogh
Noting change in HISTORY. RE:natcap#1412
605deac
phargogh added a commit to phargogh/invest that referenced this issue Oct 6, 2023
@phargogh
Adding a docstring.
6e20a0b 
RE:natcap#1412.
phargogh added a commit to phargogh/invest that referenced this issue Oct 6, 2023
@phargogh
Adding docstrings for new functions.
d9e72e7 
RE:natcap#1412
phargogh added a commit to phargogh/invest that referenced this issue Oct 6, 2023
@phargogh
Testing masking.
13c955a 
RE:natcap#1412
@phargogh phargogh mentioned this issue Oct 6, 2023
Merged
1 task
phargogh added a commit to phargogh/invest that referenced this issue Oct 9, 2023
@phargogh
Explicitly using existing numpy dtype instead of deriving it.
093e1ef 
This is more compatible with more versions of pygeoprocessing.  Using
numpy to derive the dtype, while functional, was more complicated and
feature-rich than what we actually need here.

RE:natcap#1412
phargogh added a commit to phargogh/invest that referenced this issue Oct 9, 2023
@phargogh
Using utils' array equals nodata instead of the pygeoprocessing one. RE:
c8c7493 
natcap#1412
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phargogh phargogh

Labels
bug Something isn't working in progress This issue is actively being worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updating raster masking in NDR phargogh/invest
1 participant
@phargogh