Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the workbench package a static User Guide? #851

Closed
davemfish opened this issue Dec 8, 2021 · 8 comments
Closed

Should the workbench package a static User Guide? #851

davemfish opened this issue Dec 8, 2021 · 8 comments
Assignees
Labels
in progress This issue is actively being worked on workbench For issues relating to the workbench front-end of invest
Milestone

Comments

@davemfish
Copy link
Contributor

Or is it okay to link to an online version? Right now we link to the lastest UG build on our releases bucket, but it's also possible to link to a specific version, whether it is local or online.

@dcdenu4
Copy link
Member

dcdenu4 commented Dec 10, 2021

I think it makes sense to point to the latest version, since our current UG workflow has us updating the doc with changes that would apply to the latest release of InVEST. I think it would be a nice option to have the UG locally, knowing that the local version could get out of sync with the latest version (this is how it currently is with InVEST).

@davemfish davemfish added the workbench For issues relating to the workbench front-end of invest label Feb 7, 2022
@davemfish davemfish transferred this issue from natcap/invest-workbench Feb 7, 2022
@davemfish
Copy link
Contributor Author

@emlys , @phargogh @dcdenu4 should we revisit this question before the release? Right now we're still not packing a static UG with the workbench.

@davemfish davemfish added the question Further information is requested label Mar 1, 2023
@dcdenu4
Copy link
Member

dcdenu4 commented Mar 1, 2023

Oh interesting, I think during our chat in the Software Call some of us were assuming it was. I think that discussion was around knowing which version of InVEST corresponds to which version of the UG.

How much of a lift would this be @davemfish to include the html pages locally, maybe via the About menu or something?

@davemfish
Copy link
Contributor Author

davemfish commented Mar 1, 2023

Each model tab has a link to its UG. So I think we would point that to the local html instead of the remote URL. It seems best to go with one or the other rather than having UI links to both the static and remote/latest versions in different places. That would be confusing the for user, I think. So is it debatable which version is best to provide?

Also need to configure electron builder to include the files as extra resources. And make sure our Workbench build step depends on the UG build step.

@phargogh
Copy link
Member

phargogh commented Mar 2, 2023

From my perspective, I think it'd be useful to continue to distribute the documentation for the version that people are using. We've had offline access to InVEST for a long time, so I think we should provide some documentation along with that.

I asked Tong how CAS uses the InVEST UG, and they host their own copy somewhere on their servers to avoid the firewall, and users also use the local copies of the docs that come with InVEST. So if we're linking to our own online hosted documentation from the workbench, there's an extra step people would need to go through (changing the URL to the CAS-hosted one) in order to get to the docs. Local documentation gets around the whole issue.

@davemfish
Copy link
Contributor Author

I agree with the reasons to package the UG. Related to #1102 , should we package all the available language versions? It looks like they are <10MB each, so maybe we should?

@davemfish davemfish self-assigned this Mar 3, 2023
@davemfish
Copy link
Contributor Author

Yes, we should package all language versions

davemfish added a commit to davemfish/invest that referenced this issue Mar 6, 2023
davemfish added a commit to davemfish/invest that referenced this issue Mar 6, 2023
davemfish added a commit to davemfish/invest that referenced this issue Mar 8, 2023
davemfish added a commit to davemfish/invest that referenced this issue Mar 8, 2023
davemfish added a commit to davemfish/invest that referenced this issue Mar 8, 2023
davemfish added a commit to davemfish/invest that referenced this issue Mar 8, 2023
davemfish added a commit to davemfish/invest that referenced this issue Mar 10, 2023
davemfish added a commit to davemfish/invest that referenced this issue Mar 10, 2023
davemfish added a commit to davemfish/invest that referenced this issue Mar 10, 2023
davemfish added a commit to davemfish/invest that referenced this issue Mar 10, 2023
davemfish added a commit to davemfish/invest that referenced this issue Mar 10, 2023
davemfish added a commit to davemfish/invest that referenced this issue Mar 10, 2023
davemfish added a commit to davemfish/invest that referenced this issue Mar 10, 2023
davemfish added a commit to davemfish/invest that referenced this issue Mar 11, 2023
davemfish added a commit to davemfish/invest that referenced this issue Mar 11, 2023
davemfish added a commit to davemfish/invest that referenced this issue Mar 13, 2023
@davemfish davemfish added in progress This issue is actively being worked on and removed question Further information is requested labels Mar 13, 2023
davemfish added a commit to davemfish/invest that referenced this issue Mar 13, 2023
davemfish added a commit to davemfish/invest that referenced this issue Mar 15, 2023
@phargogh
Copy link
Member

Closed in #1244

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress This issue is actively being worked on workbench For issues relating to the workbench front-end of invest
Projects
None yet
Development

No branches or pull requests

3 participants