Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delineate_watersheds_d8 does not handle the case where SRS is undefined #254

Closed
phargogh opened this issue Apr 12, 2022 · 0 comments · Fixed by #338
Closed

delineate_watersheds_d8 does not handle the case where SRS is undefined #254

phargogh opened this issue Apr 12, 2022 · 0 comments · Fixed by #338
Assignees
Labels
bug Something isn't working in progress Working on it!
Milestone

Comments

@phargogh
Copy link
Member

D8 watershed delineation implicitly requires that the flow direction raster has a defined spatial reference and doesn't handle the case where the SRS might not be defined. The projection is not actually used in the delineation, it's only assigned to the output datasets. So, we should handle this case and allow watershed delineation to proceed or throw an error and make this really explicit.

We should also make sure that the flow direction raster and outflow vector have the same projections or that both have no projection.

@phargogh phargogh added the bug Something isn't working label Apr 12, 2022
@phargogh phargogh added this to the 2.4.1 milestone Aug 1, 2023
@phargogh phargogh self-assigned this Aug 27, 2023
@phargogh phargogh added the in progress Working on it! label Aug 27, 2023
phargogh added a commit to phargogh/pygeoprocessing that referenced this issue Aug 27, 2023
Also noting this change in HISTORY and testing.

RE:natcap#254
phargogh added a commit to phargogh/pygeoprocessing that referenced this issue Aug 27, 2023
phargogh added a commit to phargogh/pygeoprocessing that referenced this issue Aug 29, 2023
phargogh added a commit to phargogh/pygeoprocessing that referenced this issue Aug 29, 2023
phargogh added a commit to phargogh/pygeoprocessing that referenced this issue Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in progress Working on it!
Projects
None yet
1 participant