Text support #1
Open
Text support #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoiding the errors shown in the Firefox console about no defined charset.
There were some security features preventing just loading up the normal HTML, so I added the instructions to avoid those. I also cleaned up the code a little bit to my liking.
No need for repeated inline styles when the CSS can handle it for all of them.
The feature is working, albeit not as well as I'd hoped. The canvas height is still way off, so I'm looking for a way to correct that before pushing a PR.
The image isn't way taller than necessary now, so it's right on par with the image-generated text now.
Implementing those features isn't feasible at the moment. If users really want that deep level of customization, they can either implement it and push it themselves or generate the image on another site like before.
Instead of expecting users to run the example.html file to see the new feature in action, it's now easily explained so they can use it right away.
Now the library can be imported into a React project without the linter yelling about using an 'undefined' variable and '==' instead of '==='
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now users can add a
data-lettercrap-textattribute with the text they want shown instead of an image, by generating an image locally via a canvas.I also added documentation for how to run the example folder locally, since security has issues with opening images from just the HTML file when not on a server.
Edit: if you could add the
hacktoberfest-acceptedlabel to this PR as explained here, should you decide to merge it, it would be greatly appreciated. I'm hoping for this to count towards my Hacktoberfest PR count.