Skip to content
This repository has been archived by the owner on Sep 5, 2020. It is now read-only.

Using more linters #11

Closed
jonathantneal opened this issue Feb 2, 2016 · 2 comments
Closed

Using more linters #11

jonathantneal opened this issue Feb 2, 2016 · 2 comments

Comments

@jonathantneal
Copy link

I love that you’re using ESLint to handle code conformance, but I see that it’s targeting correctness and style conformity.

I recommend checking out JSCS. It’s a style linter that focuses on enforcing your style guide. It might be nice to separate error prevention and pattern conformity with styling.

There’s a lot a great tool for enforcing style conformity in CSS files. It’s called StyleLint. It has hundreds of rules that define how you want CSS to look.

There are Atom and Sublime plugins for ESLint, JSCS, and StyleLint, so you can attack this from the IDE and/or the build process.

If you’re interested, I’ve also written .eslintrc, .jscsrc, and .stylelintrc files that should be close to the patterns you once taught me, if they aren’t exact. I could put those into a PR if you are interested.

@natecavanaugh
Copy link
Contributor

Heya Jon,
Thanks for the issue :)
I have definitely wanted to have a better way of making a distinction between errors ("this is broken, don't do it"), warnings ("this looks broken, and/or could cause issues"), and style violations ("we like tabs, not spaces, your pull request won't get accepted, but the world won't end").

I will for sure check out StyleLint (hopefully it's as customizable as ESLint is as regards writing custom rules :)

For the .rc files, could you attach them to this ticket? That way you don't have to put them anywhere in particular, and since they're not being used, I can pull them down when I integrate the others.

(Though we do have our rules for eslint configured here)

Thanks again for filing this :)

@wincent
Copy link
Contributor

wincent commented Sep 4, 2020

We're going to be archiving this project so closing everything.

@wincent wincent closed this as completed Sep 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants