LPS-47844 Replace user portraits (Default Avatar has borders and looks bad on rounded thumbnails) #2565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riginal classes for backward compatibility
juliocamarero
changed the title
|
Some tests have FAILED. ❌ |
|
Heya Julio, thanks for sending this. Could you have Juan do a few more iterations on this? As it is, there are just some things about it that seem off (it's a little too bubbly, when it's off-center it looks strange with the circle shape, etc). Conceptually it's not a bad idea, though part of me wonders if we should have the female version be caris' outline :) Maybe something like the launch party glasses that were made? You can email meif you dont remember what they look like. Thanks Julio! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
designed by @juanhidalgoreina!