LPS-65325 changes to horizontal and vertical theme

[juliocamarero]

No description provided.

[juliocamarero]

cc @marcoscv-work

[juliocamarero]

@drewbrokke @pei-jung I have moved the logic from the themes about users to a theme context contributor in the users-admin-web module.

Can you please have a look?

thanks!

[natecavanaugh]

@juliocamarero With moving the user variables out of the unstyled theme, doesn't this technically break backwards compatibility, since any theme that's using those vars will now break?
Or were they only recently added?
Either way, I think we'll have to bump the version on it won't we?

Thanks guys,

[juliocamarero]

Hey Nate,

Nothing changes for other themes. Now the same variables are injected
before the execution of init.ftl in the theme.

This just makes the themes lighter and the execution faster, but it's a
transparent change for developers.
El El mar, 26 abr 2016 a las 19:02, Nate Cavanaugh notifications@github.com
escribió:

@juliocamarero https://github.com/juliocamarero With moving the user
variables out of the unstyled theme, doesn't this technically break
backwards compatibility, since any theme that's using those vars will now
break?
Or were they only recently added?
Either way, I think we'll have to bump the version on it won't we?

Thanks guys,

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#3977 (comment)

[pei-jung]

Hey @juliocamarero,

Should we also remove the user variables in the velocity templates (https://github.com/liferay/liferay-portal/blob/master/modules/apps/foundation/frontend-theme/frontend-theme-unstyled/src/main/resources/META-INF/resources/_unstyled/templates/init.vm#L44-L62) in 065fbd9?

[natecavanaugh]

@juliocamarero Thanks for the info. Makes sense :)

@pei-jung I believe 065fbd9 already has those removed? Unless I misunderstood what you meant.

[pei-jung]

Hey @natecavanaugh,

Those variables are only removed in the freemarker template init.ftl but not the velocity template init.vm. I'm not sure if the context contributor will inject the variables to both templates. That's why I wonder if the variables in the velocity should be removed or not.

[natecavanaugh]

Ahhh sorry, I misread what you pasted. I'll leave that one to Julio to answer :)

[pei-jung]

@natecavanaugh That's alright. I should've just linked the url instead of pasting the whole thing. That way, it's more clear :)

[juliocamarero]

Yes, you are right @pei-jung !! Sorry I missed that one! I forgot we still have the vm files.

I just added another commit.

thanks a lot!!

[natecavanaugh]

Merged and pushed to Brian. Thanks :)
Pull request submitted at: brianchandotcom#39130
View total diff: 56a88d8...3e12641

[drewbrokke]

@juliocamarero thanks for letting us know about this.

Good catch, @pei-jung!