Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a go.mod #65

Open
andradei opened this issue Aug 30, 2018 · 2 comments
Open

Create a go.mod #65

andradei opened this issue Aug 30, 2018 · 2 comments

Comments

@andradei
Copy link

To make this package module-aware.

@natefinch
Copy link
Owner

natefinch commented Aug 31, 2018 via email

@xiegeo
Copy link

xiegeo commented Sep 1, 2018

Right now the package imports fine by go mod, it shows as gopkg.in/natefinch/lumberjack.v2 v2.0.0-20170531160350-a96e63847dc3 in my downstream project.

The only problem is that the tag v2.1 is not Semver, so it probably needs a new v2.1.1 tag for it to show as v2.1.1 instead of v2.0.0-20170531160350-a96e63847dc3.

There are no build dependencies, however adding a go.mod file will help with defining test dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants