Multiple enhancements #158
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fahedouch
force-pushed
the
add-max-bytes-and-deprecate-max-size
branch
from
df54f04
to
139d774
Compare
Open
fahedouch
force-pushed
the
add-max-bytes-and-deprecate-max-size
branch
from
334068e
to
afa46a6
Compare
Signed-off-by: Fahed DORGAA <fahed_dorgaa@carrefour.com>
fahedouch
force-pushed
the
add-max-bytes-and-deprecate-max-size
branch
from
afa46a6
to
9ccd96e
Compare
|
cc @natefinch |
|
I made similar changes in the v3 branch. I'm not sure that maxsize = -1 is a good idea? Is there some other way you'd be managing file size? |
|
hey @natefinch , sorry for the delayed reply. mmmh I think that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-1Signed-off-by: Fahed DORGAA fahed_dorgaa@carrefour.com