Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json #5

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Update package.json #5

merged 1 commit into from
Jan 16, 2024

Conversation

WHG555
Copy link
Contributor

@WHG555 WHG555 commented Jan 10, 2024

修改包的版本,以支持低一点的版本。
目录支持obsidian 1.1.16 dataview 0.5.46

修改包的版本
Copy link
Owner

@natefrisch01 natefrisch01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! Did you test with these versions? If so I agree with your suggested "obsidian-dataview": "^0.5.43",. Also, I agree that we should set a specific version for obsidian, but I believe a newer version may work better? I'm using

+-- obsidian-dataview@0.5.64
| `-- obsidian-calendar-ui@0.3.12
|   `-- obsidian-daily-notes-interface@0.8.4
|     `-- obsidian@1.5.1 (git+ssh://git@github.com/obsidianmd/obsidian-api.git#bbb696aeb8bf5126bf2ecbf84fc8284fe133bc20)
`-- obsidian@1.4.11

Have any thoughts?

@WHG555
Copy link
Contributor Author

WHG555 commented Jan 11, 2024

是的 我自己的版本就是 obsidian 1.1.16 dataview 0.5.46
将它们编译后,就支持这两个版本,并且可以正常使用。
你也可以测试一下。能支持旧版本的ob与dataview当然会更好。毕竟基本ob的工作流搭建好了之后,ob的版本与插件的版本基本不会更新。

@natefrisch01
Copy link
Owner

Good thoughts - I'm new to developing plugins, so I'm not sure what the standard practices are. I'll test on my machine and if it works I'll merge it in. Thanks for your help!

@WHG555
Copy link
Contributor Author

WHG555 commented Jan 13, 2024

How's the test?

@natefrisch01
Copy link
Owner

Sorry I haven't done it yet! - I'm planning to take a look at these around 1/16

@natefrisch01 natefrisch01 merged commit 5c8905e into natefrisch01:master Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants