Target .NET6 instead of .NET Standard 2.0 and .NET Core 3.1 #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ix variety of arising nullability errors
Codecov Report
@@ Coverage Diff @@
## main #280 +/- ##
==========================================
- Coverage 46.16% 45.77% -0.39%
==========================================
Files 45 45
Lines 1120 1112 -8
==========================================
- Hits 517 509 -8
Misses 603 603
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
natemcmaster
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@natemcmaster to ease reviewing, here's a PR that just changes the target framework.
I have not taken a look at your CI scripts, so there may be some work required for them.(edit: they seem to work)A PR for the other feature will follow :)
The review is probably easier on a per-commit basis, I tried to make them as small and concise as possible, especially trying to separate gardening and actual changes.