fix(createIconPack): handle unresolved modules (#148)

Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
natemoo-re · Dec 5, 2023 · d176a7d · d176a7d · vercel · Dec 5, 2023
1 parent 832ac05
commit d176a7d
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/.changeset/great-carpets-hide.md b/.changeset/great-carpets-hide.md
@@ -0,0 +1,5 @@
+---
+"astro-icon": patch
+---
+
+Fixes an edge case with `createIconPack` when a module cannot be resolved
diff --git a/packages/core/lib/createIconPack.ts b/packages/core/lib/createIconPack.ts
@@ -15,7 +15,14 @@ export function createIconPack({
 }: CreateIconPackOptions) {
   if (pkg) {
     return async (name: string) => {
-      const baseUrl = new URL(pathToFileURL(resolvePackage(pkg)) + "/");
+      const pkgPath = resolvePackage(pkg);
+      if (!pkgPath) {
+        throw new Error(
+          `[astro-icon] Unable to resolve "${pkgPath}"! Is the package installed?"`
+        );
+      }
+
+      const baseUrl = new URL(pathToFileURL(pkgPath) + "/");
       const path = fileURLToPath(
         new URL(dir ? `${dir}/${name}.svg` : `${name}.svg`, baseUrl)
       );