Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typings #113

Merged
merged 2 commits into from Jun 6, 2023
Merged

Fix typings #113

merged 2 commits into from Jun 6, 2023

Conversation

stramel
Copy link
Collaborator

@stramel stramel commented Jun 6, 2023

This PR addresses build and typing issues. The code should be in a usable state after this merge.

Changes:

  • Extended Icon Props to allow for HTMLAttributes<'svg'>
  • Added an initial generation of the icon typing at the start of the integration
  • Our repo was conflicting on the type resolution for the Icon typing so I had to add baseUrl: './' to prevent them from overlapping. I'm not sure if this is the "correct" fix.

@stramel stramel added this to the v1 milestone Jun 6, 2023
@stramel stramel requested a review from natemoo-re June 6, 2023 03:26
@stramel stramel self-assigned this Jun 6, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jun 6, 2023

⚠️ No Changeset found

Latest commit: 43927e9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jun 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-astroicon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2023 3:36am
astroicon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2023 3:36am

@vercel
Copy link

vercel bot commented Jun 6, 2023

Deployment failed with the following error:

Resource is limited - try again in 37 minutes (more than 100, code: "api-deployments-free-per-day").

@natemoo-re natemoo-re merged commit d949ccb into v1 Jun 6, 2023
3 of 4 checks passed
@natemoo-re natemoo-re deleted the ms/v1-clean-up branch June 6, 2023 23:10
natemoo-re pushed a commit that referenced this pull request Dec 21, 2023
* fix build

* chore(lint): Prettier fix

---------

Co-authored-by: Michael Stramel <michael.stramel@koyfin.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
natemoo-re pushed a commit that referenced this pull request Dec 22, 2023
* fix build

* chore(lint): Prettier fix

---------

Co-authored-by: Michael Stramel <michael.stramel@koyfin.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
natemoo-re pushed a commit that referenced this pull request Dec 22, 2023
* fix build

* chore(lint): Prettier fix

---------

Co-authored-by: Michael Stramel <michael.stramel@koyfin.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
natemoo-re pushed a commit that referenced this pull request Dec 22, 2023
* fix build

* chore(lint): Prettier fix

---------

Co-authored-by: Michael Stramel <michael.stramel@koyfin.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
natemoo-re pushed a commit that referenced this pull request Dec 22, 2023
* fix build

* chore(lint): Prettier fix

---------

Co-authored-by: Michael Stramel <michael.stramel@koyfin.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants