Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move warning about local directory to on use #123

Merged
merged 2 commits into from Jun 30, 2023
Merged

Conversation

stramel
Copy link
Collaborator

@stramel stramel commented Jun 30, 2023

Moves the warning about a missing local directory/collection to only apply on usage of a local icon

@stramel stramel added the enhancement New feature or request label Jun 30, 2023
@stramel stramel added this to the v1 milestone Jun 30, 2023
@stramel stramel requested a review from natemoo-re June 30, 2023 04:43
@stramel stramel self-assigned this Jun 30, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jun 30, 2023

🦋 Changeset detected

Latest commit: 0e2baed

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro-icon Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-astroicon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 30, 2023 4:44am
astroicon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 30, 2023 4:44am

@stramel stramel changed the base branch from main to v1 June 30, 2023 04:43
@stramel stramel merged commit 41554ad into v1 Jun 30, 2023
6 of 7 checks passed
@stramel stramel deleted the ms/move-local-dir-warning branch June 30, 2023 04:46
@github-actions github-actions bot mentioned this pull request Jun 30, 2023
natemoo-re pushed a commit that referenced this pull request Dec 21, 2023
Co-authored-by: Michael Stramel <michael.stramel@koyfin.com>
natemoo-re pushed a commit that referenced this pull request Dec 22, 2023
Co-authored-by: Michael Stramel <michael.stramel@koyfin.com>
natemoo-re pushed a commit that referenced this pull request Dec 22, 2023
Co-authored-by: Michael Stramel <michael.stramel@koyfin.com>
natemoo-re pushed a commit that referenced this pull request Dec 22, 2023
Co-authored-by: Michael Stramel <michael.stramel@koyfin.com>
natemoo-re pushed a commit that referenced this pull request Dec 22, 2023
Co-authored-by: Michael Stramel <michael.stramel@koyfin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant